Add new dashboard/assets #2607
Draft
Add new dashboard/assets #2607
+2,460
−354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR deployed in Google Cloud |
|
PR deployed in Google Cloud |
kattylucy
force-pushed
the
2585_assets_page
branch
8 times, most recently
from
a6ef4d3 to
5e7a8c8
Compare
onnovisser
reviewed
Jan 30, 2025
| @@ -157,13 +157,13 @@ export function AssetTransactions({ pool }: { pool: Pool }) { | |||
| }) | |||
| } | |||
| } | |||
| }, [transactions, setCsvData]) | |||
| }, [transactions, setCsvData, explorer]) | |||
There was a problem hiding this comment.
explorer shouldn't be here, because it's not stable. Would just eslint ignore instead
onnovisser
reviewed
Jan 30, 2025
| children: ReactNode | ||
| } | ||
|
|
||
| export const SelectedPoolsProvider: React.FC<SelectedPoolsProviderProps> = ({ children }) => { |
onnovisser
reviewed
Jan 30, 2025
centrifuge-app/src/utils/useLoans.ts
Outdated
| return loans?.find((loan) => loan.id === assetId) | ||
| } | ||
|
|
||
| export function useAvailableFinancing(poolId: string, assetId: string) { | ||
| const isTinlakePool = poolId.startsWith('0x') | ||
| const isTinlakePool = poolId.length === 1 && poolId[0].startsWith('0x') |
There was a problem hiding this comment.
const isTinlakePool = poolId.startsWith('0x') seems fine here, as poolId is not an array here
kattylucy
force-pushed
the
2585_assets_page
branch
6 times, most recently
from
541b922 to
915c940
Compare
kattylucy
force-pushed
the
2585_assets_page
branch
from
2b5c5f5 to
43429eb
Compare
kattylucy
force-pushed
the
2585_assets_page
branch
from
43429eb to
cf45d42
Compare
kattylucy
force-pushed
the
2585_assets_page
branch
from
340df13 to
7e7b8c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request...
#
Approvals
Screenshots
Impact